fix: stop accumulating WhenAny continuations on the Conditions aggregate#562
Merged
Conversation
kinyoklion
approved these changes
Jun 22, 2026
Merged
beekld
pushed a commit
that referenced
this pull request
Jun 29, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.11.2</summary> ## [3.11.2](launchdarkly-cpp-client-v3.11.1...launchdarkly-cpp-client-v3.11.2) (2026-06-29) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/cpp-internal bumped from 0.13.0 to 0.14.0 * @launchdarkly/cpp-common bumped from 1.11.0 to 1.12.0 * @launchdarkly/cpp-sse-client bumped from 0.6.1 to 0.7.0 </details> <details><summary>launchdarkly-cpp-common: 1.12.0</summary> ## [1.12.0](launchdarkly-cpp-common-v1.11.0...launchdarkly-cpp-common-v1.12.0) (2026-06-29) ### Features * expose Big Segments via public Client and Config APIs ([#552](#552)) ([c5fd239](c5fd239)) </details> <details><summary>launchdarkly-cpp-internal: 0.14.0</summary> ## [0.14.0](launchdarkly-cpp-internal-v0.13.0...launchdarkly-cpp-internal-v0.14.0) (2026-06-29) ### Features * add internal BigSegmentStoreWrapper with caching and status polling ([#543](#543)) ([47fa5c2](47fa5c2)) * orchestrator switches to FDv1 fallback on directive ([#539](#539)) ([44f2522](44f2522)) ### Bug Fixes * FDv2 fixes surfaced by v3 contract test harness ([#547](#547)) ([e9c3c04](e9c3c04)) * handle FDv2 intentCode none as listening, reject unknown codes ([#555](#555)) ([42e8ecd](42e8ecd)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/cpp-common bumped from 1.11.0 to 1.12.0 </details> <details><summary>launchdarkly-cpp-server: 3.11.0</summary> ## [3.11.0](launchdarkly-cpp-server-v3.10.1...launchdarkly-cpp-server-v3.11.0) (2026-06-29) ### Features * add FDv1AdapterSynchronizer wrapping IDataSynchronizer as IFDv2Synchronizer ([#540](#540)) ([d6368b8](d6368b8)) * add FDv2 configuration builder ([#545](#545)) ([43850ce](43850ce)) * add IBigSegmentStore interface + Redis and DynamoDB stores ([#536](#536)) ([136aca7](136aca7)) * add internal BigSegmentsBuilder + config struct ([#541](#541)) ([3c88c2a](3c88c2a)) * add internal BigSegmentStoreWrapper with caching and status polling ([#543](#543)) ([47fa5c2](47fa5c2)) * add server FDv2 data system orchestrator ([#529](#529)) ([65e110f](65e110f)) * add X-LaunchDarkly-Instance-Id header to server SDK (SDK-2353) ([#532](#532)) ([fd0c761](fd0c761)) * evaluate big segments ([#550](#550)) ([505ee46](505ee46)) * expose Big Segments via public Client and Config APIs ([#552](#552)) ([c5fd239](c5fd239)) * orchestrator switches to FDv1 fallback on directive ([#539](#539)) ([44f2522](44f2522)) * propagate FDv1 fallback directive from FDv2 polling and streaming sources ([#538](#538)) ([edd96fe](edd96fe)) ### Bug Fixes * FDv2 fixes surfaced by v3 contract test harness ([#547](#547)) ([e9c3c04](e9c3c04)) * stop accumulating WhenAny continuations on the Conditions aggregate ([#562](#562)) ([5f8bf79](5f8bf79)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/cpp-internal bumped from 0.13.0 to 0.14.0 * @launchdarkly/cpp-common bumped from 1.11.0 to 1.12.0 * @launchdarkly/cpp-sse-client bumped from 0.6.1 to 0.7.0 </details> <details><summary>launchdarkly-cpp-server-dynamodb-source: 0.2.0</summary> ## [0.2.0](launchdarkly-cpp-server-dynamodb-source-v0.1.0...launchdarkly-cpp-server-dynamodb-source-v0.2.0) (2026-06-29) ### Features * add IBigSegmentStore interface + Redis and DynamoDB stores ([#536](#536)) ([136aca7](136aca7)) * add internal BigSegmentStoreWrapper with caching and status polling ([#543](#543)) ([47fa5c2](47fa5c2)) * implement DynamoDBDataSource + tests ([#534](#534)) ([a0c2790](a0c2790)) * scaffold libs/server-sdk-dynamodb-source ([#533](#533)) ([df386c1](df386c1)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/cpp-server bumped from 3.10.1 to 3.11.0 </details> <details><summary>launchdarkly-cpp-server-otel: 0.1.2</summary> ## [0.1.2](launchdarkly-cpp-server-otel-v0.1.1...launchdarkly-cpp-server-otel-v0.1.2) (2026-06-29) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/cpp-server bumped from 3.10.1 to 3.11.0 </details> <details><summary>launchdarkly-cpp-server-redis-source: 2.3.0</summary> ## [2.3.0](launchdarkly-cpp-server-redis-source-v2.2.2...launchdarkly-cpp-server-redis-source-v2.3.0) (2026-06-29) ### Features * add IBigSegmentStore interface + Redis and DynamoDB stores ([#536](#536)) ([136aca7](136aca7)) * add internal BigSegmentStoreWrapper with caching and status polling ([#543](#543)) ([47fa5c2](47fa5c2)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/cpp-server bumped from 3.10.1 to 3.11.0 </details> <details><summary>launchdarkly-cpp-sse-client: 0.7.0</summary> ## [0.7.0](launchdarkly-cpp-sse-client-v0.6.1...launchdarkly-cpp-sse-client-v0.7.0) (2026-06-29) ### Features * propagate FDv1 fallback directive from FDv2 polling and streaming sources ([#538](#538)) ([edd96fe](edd96fe)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > The diff is mechanical versioning and changelog updates only; functional risk is whatever shipped in prior commits now being tagged, not new logic in this PR. > > **Overview** > This PR is a **Release Please** cut that updates `.release-please-manifest.json`, workspace `package.json` dependency pins, CMake `VERSION` lines, embedded SDK version strings, version assertion tests, and **CHANGELOG** entries—no feature or bugfix code appears in the diff itself. > > The release packages **server SDK 3.11.0** (FDv2 orchestration/config, FDv1 fallback from streaming/polling, big-segment evaluation and public APIs, Redis/DynamoDB `IBigSegmentStore`, `X-LaunchDarkly-Instance-Id`), plus **client 3.11.2** and bumps for **common 1.12.0**, **internal 0.14.0**, **SSE 0.7.0**, **redis-source 2.3.0**, **dynamodb-source 0.2.0**, and **otel 0.1.2**. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 48e3593. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FDv2 data system's
Conditions::GetFuture()previously returned the same shared future to every iteration ofRunSynchronizerNext, so each iteration'sWhenAny(cond_future, next_future).Then(...)appended a callback to the shared future'scontinuations_vector. On a healthy primary streaming changesets without ever firing fallback/recovery, those continuations accumulated for the synchronizer's lifetime.Conditions::GetFuture(token)now returns a fresh Future per call.CancellationSourceafter the WhenAny resolves.Conditions.Analogous to launchdarkly/java-core#163.
Note
Medium Risk
Touches FDv2 orchestration and async cancellation ordering (locks around
CancellationCallback); behavior change is localized but long-running streaming paths depend on correct cleanup.Overview
Fixes unbounded growth of
WhenAnycontinuation callbacks during long-lived primary streaming, where eachRunSynchronizerNextloop reused one sharedConditionsfuture.Conditions::GetFuturenow takes aCancellationTokenand returns a new future per call. A single internal aggregate listener still watches the first condition to fire; when it resolves, it fans out to all pending per-call promises.Closealso drains any still-pending waiters withkCancelled.Callers (notably
FDv2DataSystem::RunSynchronizerNext) create a per-iterationCancellationSource, pass its token intoGetFuture, and cancel afterWhenAnycompletes so the pending entry and its promise/continuations can be dropped. Token cancellation removes the waiter from the pending list if the race finishes early.Tests updated to pass a
CancellationTokenintoGetFuture.Reviewed by Cursor Bugbot for commit af09001. Bugbot is set up for automated code reviews on this repo. Configure here.